-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue1017] Allow running Ubuntu workflow for repos with arbitrary names. #38
Conversation
My patch doesn't work when LP solvers are present. I'm working on a fix now. |
Now it should work with and without the secrets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of my comments basically relate to the fact that I find the paths used by Github actions somewhat obscure. If you understood how they work, I would appreciate if you either documented the paths implicitly used when checking out/compiling/moving directories or to explicitly provide the paths (e.g., use cd /home/runner/downward even if this is not necessary etc.).
.github/workflows/ubuntu.yml
Outdated
steps: | ||
# Check out repo at $GITHUB_WORKSPACE (= /home/runner/work/my-repo/my-repo). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting to know, but how does the compilation of the planner below work without switching to this directory?
Wouldn't it make sense to have this path more explicitly, i.e., checkout to downward in home (= /home/runner) so that we have one directory for the planner and one for the libraries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checkout path is configurable, but it must lie under $GITHUB_WORKSPACE.
No description provided.